Skip to content

fix: propagate kwargs to remake_initialization_data #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: propagate kwargs to remake_initialization_data #978

wants to merge 1 commit into from
+2 −2

Conversation

@vyudu
Copy link
Member

@vyudu vyudu commented Mar 31, 2025

No description provided.

@vyudu vyudu mentioned this pull request Mar 31, 2025
Open
AayushSabharwal
AayushSabharwal requested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@AayushSabharwal AayushSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking. The method in MTK doesn't have kwargs, so this will never dispatch to it.

@vyudu
Copy link
Member Author

vyudu commented Apr 1, 2025 via email

@AayushSabharwal
Copy link
Member

It's still breaking, because this version of SciMLBase won't work with older versions of MTK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AayushSabharwal AayushSabharwal AayushSabharwal requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vyudu @AayushSabharwal